style(agents): unquote ApprovalHandler annotation (resolve unused-import nit)#305
Merged
Merged
Conversation
The Awaitable in the ApprovalHandler type alias was inside a quoted forward-ref, so a naive unused-import check (github-code-quality) flagged the collections.abc Awaitable import as unused (ruff/pyright saw it fine). Unquote the annotation — ApprovalHandler is a runtime assignment and all names are imported, so it evaluates cleanly and Awaitable is now a genuine reference. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial follow-up to PR #304. The
Awaitablein theApprovalHandlertype alias sat inside a quoted forward-reference, so github-code-quality flagged thecollections.abc.Awaitableimport as unused (ruff/pyright parse forward-refs and were clean). Unquoting the annotation makesAwaitablea genuine runtime reference —ApprovalHandleris a module-level assignment and all names are imported, so it evaluates fine. No behaviour change; 25 HITL tests + pyright/ruff clean.