Skip to content

Refactor entity detail selection#28

Merged
ktsaou merged 1 commit into
mainfrom
quality-entity-detail-selection-complexity
Jun 4, 2026
Merged

Refactor entity detail selection#28
ktsaou merged 1 commit into
mainfrom
quality-entity-detail-selection-complexity

Conversation

@ktsaou

@ktsaou ktsaou commented Jun 4, 2026

Copy link
Copy Markdown
Member

Summary

  • move selected entity detail aggregation into a dedicated builder
  • split target initialization, feed ordering, country/ASN contributions, and final sidecar construction
  • cover country and ASN target detection helpers

Validation

  • go test ./pkg/engine
  • go test -coverprofile=/tmp/update-ipsets-engine-slice24.cover -covermode=atomic ./pkg/engine
  • go run ./tools/archposture -root . > /tmp/update-ipsets-archposture-slice24.json
  • make lint
  • make staticcheck
  • make golangci-lint
  • CI=true make coverage
  • make test-strict
  • git diff --check

@ktsaou ktsaou enabled auto-merge June 4, 2026 02:42
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 20 complexity · -2 duplication

Metric Results
Complexity 20
Duplication -2

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@ktsaou ktsaou merged commit 1350bc9 into main Jun 4, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant