Skip to content

Refactor ASN database processing#29

Merged
ktsaou merged 1 commit into
mainfrom
quality-asn-database-processing-complexity
Jun 4, 2026
Merged

Refactor ASN database processing#29
ktsaou merged 1 commit into
mainfrom
quality-asn-database-processing-complexity

Conversation

@ktsaou

@ktsaou ktsaou commented Jun 4, 2026

Copy link
Copy Markdown
Member

Summary

  • move ASN provider lifecycle handling into focused helpers
  • keep processASNDatabases responsible for orchestration, cancellation, and close-on-error cleanup
  • cover invalid format, missing database, staged archive, successful load, and open-failure paths

Validation

  • go test ./pkg/engine
  • go test -coverprofile=/tmp/update-ipsets-engine-slice25.cover -covermode=atomic ./pkg/engine
  • go run ./tools/archposture -root . > /tmp/update-ipsets-archposture-slice25.json
  • make lint
  • make staticcheck
  • make golangci-lint
  • CI=true make coverage
  • make test-strict
  • git diff --check

@ktsaou ktsaou enabled auto-merge June 4, 2026 03:00
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 70 complexity · 5 duplication

Metric Results
Complexity 70
Duplication 5

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@ktsaou ktsaou merged commit 05218cb into main Jun 4, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant