Skip to content

Refactor entity detail facet aggregation#30

Merged
ktsaou merged 1 commit into
mainfrom
quality-entity-detail-aggregation-duplication
Jun 4, 2026
Merged

Refactor entity detail facet aggregation#30
ktsaou merged 1 commit into
mainfrom
quality-entity-detail-aggregation-duplication

Conversation

@ktsaou

@ktsaou ktsaou commented Jun 4, 2026

Copy link
Copy Markdown
Member

Summary

  • share category and maintainer aggregation across country and ASN detail builders
  • keep country-specific ASN rollups and ASN-specific country distributions separate
  • reduce source-only duplication in backend entity detail code

Validation

  • go test ./pkg/engine
  • go test -coverprofile=/tmp/update-ipsets-engine-slice26.cover -covermode=atomic ./pkg/engine
  • go run ./tools/archposture -root . > /tmp/update-ipsets-archposture-slice26.json
  • npx --yes jscpd@4.2.4 --reporters json,console --output /tmp/update-ipsets-jscpd-slice26-after --exitCode 0 --min-lines 20 --min-tokens 120 --max-lines 2000 --max-size 512kb --ignore "/*_test.go,pkg/web/static/,ui/dist/,ui/node_modules/,.agents/,tools/archposture/testdata/" cmd internal pkg tools ui/src .github/scripts
  • make lint
  • make staticcheck
  • make golangci-lint
  • CI=true make coverage
  • make test-strict
  • git diff --check

@ktsaou ktsaou enabled auto-merge June 4, 2026 03:15
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -4 complexity · -2 duplication

Metric Results
Complexity -4
Duplication -2

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@ktsaou ktsaou merged commit d116f9d into main Jun 4, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant