chore(sow)+test(downloader): rename slice label and extend /0 filter assertion#38
Open
ktsaou wants to merge 1 commit into
Open
chore(sow)+test(downloader): rename slice label and extend /0 filter assertion#38ktsaou wants to merge 1 commit into
ktsaou wants to merge 1 commit into
Conversation
Follow-up to PR #37 (which fixed the 3 real Go test issues). This addresses 2 more small, mechanical items from the same AI findings triage that were skipped in PR #37: - .agents/sow/current/SOW-0102: rename the first slice's result heading from 'Final local results' to 'First-slice local results'. The SOW now documents three slice results (First, Second, Third), so calling the first one 'Final' was misleading. - pkg/downloader: extend the /0 filter test in TestParseProcessedFeedFileSanitizesInput to also assert that 5.6.7.0 (the CIDR base address) is omitted alongside 5.6.7.1. Catches regressions where the /0 base is kept while other addresses are dropped.
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #37. Addresses 2 more small, mechanical items from the
AI code quality findings triage:
Final local resultstoFirst-slice local results. The SOW nowdocuments three slice results (First, Second, Third), so the original
Finallabel was misleading for readers scanning the document.pkg/downloader: extend the/0filter test inTestParseProcessedFeedFileSanitizesInputto also assert that5.6.7.0(the CIDR base address) is omitted alongside5.6.7.1.This catches regressions where the
/0base is kept while otheraddresses inside the range are dropped.
Diff size
Validation
go test ./pkg/downloader/...— passgo test -race ./pkg/downloader/...— passOut of scope (still)
The remaining 6 skipped findings are addressed in the PR #37 triage
table. The next-largest candidates (slice ordering, status change) are
intentionally deferred because they conflict with project conventions
or would require renumbering thousands of lines.