Skip to content

docs: address week-1 onboarding feedback#91

Draft
cshape wants to merge 1 commit into
mainfrom
docs/week1-feedback-fixes
Draft

docs: address week-1 onboarding feedback#91
cshape wants to merge 1 commit into
mainfrom
docs/week1-feedback-fixes

Conversation

@cshape

@cshape cshape commented Jun 19, 2026

Copy link
Copy Markdown

Summary

Addresses the documentation items from Cale's week-1 onboarding product/docs feedback.

Opened as a draft for review before merge.

Changes

  1. train_mode API reference — the Create Model reference advertised train_mode: "full" in the response example, but TTS model creation only supports "fast". POST /model (TTS-only) response is now const: "fast"; GET /model/{id} and the shared model schema default to "fast" while still allowing "full" for non-TTS models.
  2. [emphasis] documented — previously only mentioned in the changelog and models overview. Added as a Tone Marker with a usage example on the Emotion Control page.
  3. "Special Effects" placement — Tone Markers, Audio Effects, and Special Effects were nested under "Complete Emotion Reference" alongside actual emotions. Moved them into a new Sound & Delivery Markers section, since they aren't emotions.
  4. Latency guidance — S2 over WebSocket can take several seconds to first audio because the raw HTTP/WebSocket API defaults latency to normal (the Python SDK defaults to balanced). Added a warning and a per-surface support matrix so real-time users (e.g. via the LiveKit plugin) know to set balanced/low.

Follow-ups (not in this PR)

  • Durable train_mode fix: openapi.json is regenerated from platform-api via scripts/update-openapi.mjs. The response model in platform-api/apps/models/schemas.py (train_mode: Literal["fast","full"] = "full") is the true source — without updating it, the next regen reverts the spec edit here.
  • Emotion advice needs verification: emotions.mdx advises "Add appropriate text after sound effects (e.g., 'Ha ha' after laughing)" — likely leftover S1 guidance. Left unchanged pending confirmation of actual S2 behavior.

Validation

openapi.json validated as well-formed JSON. mint/prettier not run locally (not installed); please confirm the docs build in CI / preview.

- API reference: Create Model (POST /model) response now shows train_mode
  as const "fast" (TTS-only); GET /model/{id} and the shared model schema
  default to "fast" while still allowing "full" for non-TTS models. Fixes
  the stale "full" example in the clone/create model reference.
- Emotion Control: document the [emphasis] tone marker (previously only in
  the changelog and models overview), with usage example.
- Emotion Control: move Tone Markers, Audio Effects and Special Effects out
  from under "Complete Emotion Reference" into a new "Sound & Delivery
  Markers" section, since these are not emotions.
- Real-time streaming + TTS: clarify latency defaults. The raw HTTP/WebSocket
  API defaults to "normal" (quality-tuned, high time-to-first-audio) while
  the Python SDK defaults to "balanced"; add a warning and a per-surface
  support matrix so real-time users (e.g. via LiveKit) set balanced/low.

Note: openapi.json is regenerated from platform-api; the durable train_mode
fix also needs platform-api apps/models/schemas.py updated (follow-up).
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: edf0c42f-6573-498e-a48d-ba3b0ad2791d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/week1-feedback-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mintlify

mintlify Bot commented Jun 19, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
hanabiaiinc 🟢 Ready View Preview Jun 19, 2026, 1:07 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant