Conversation
…uting to page= form
The "Cleanup Orphaned Audio" step crashed with "Unexpected closing slash"
because speak-mintlify's injector un-nests <AudioTranscript> out of its
<Visibility for="humans"> wrapper, leaving a dangling </Visibility>. The
crash skipped the PR step, so no audio PR was ever opened.
Pages now use the runtime page= form (<AudioTranscript page="..." />):
- the cleanup command cannot see those references and would delete live audio
- there is no MDX rewrite, so there is nothing to open a PR for
Drop both steps; `generate` still uploads audio to R2, which is all the
page= form needs.
Also convert contributing.mdx from the legacy voices={...} form to the
page= form so it follows the current E-girl voice.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe TTS workflow removes the "Cleanup Orphaned Audio" and "Create Pull Request" steps, replacing them with explanatory comments. In ChangesTTS page= migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
1 participant
Description
What
Cleanup Orphaned AudioandCreate Pull Requeststeps from the TTS workflow.contributing.mdxfrom the legacyvoices={...}form to the runtimepage=form.Why
The TTS workflow was failing on every run. The
Cleanup Orphaned Audiostepcrashed with
Unexpected closing slash '/' in tag, which then skipped theCreate Pull Requeststep (noif: always()), so no audio PR was ever opened.Root cause is the page= migration (PR #68) being incompatible with the
speak-mintlifyCLI workflow, which was built for the oldvoices={...}form:referenced" by reading
voicesURLs from the MDX. Thepage=form has novoicesattribute, so cleanup sees those pages as referencing nothing andwould delete live audio. (It only ever crashed before reaching that point.)
generatere-injecting the component: itun-nests
<AudioTranscript>out of its<Visibility for="humans">wrapperand leaves a dangling
</Visibility>, which is invalid MDX.audio-transcript.jsx, so the MDX is never rewritten — there is nothing tocommit.
generatestill runs and uploads the audio to R2, which is all the page= formneeds.
contributing.mdxwas the last file still on the oldvoices={...}form (andstill pointed at the dead E-girl ID). Converting it to
page=makes all audiopages consistent and lets it follow the current voice list.
Net change
Only
.github/workflows/tts.yamlandcontributing.mdx(the E-girl voice IDfix already landed on main via #90).
Notes / follow-ups (out of scope)
generatestill re-synthesizes every page each run (~2.5h) because itsskip/dedup needs metadata in the MDX, which the page= form doesn't carry.
audio-transcript.jsx+speaker-config.yaml) and must be kept in sync.Summary by CodeRabbit