-
Notifications
You must be signed in to change notification settings - Fork 0
#10 added docs about how payment vendor side tip is handled + extend … #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e51d392
#10 added docs about how payment vendor side tip is handled + extend …
turtletramp d5f1bd1
#10 fix review feedback
turtletramp fc5b44a
Apply suggestion from @deboragracio
MaximilianFT bf0c088
Apply suggestion from @deboragracio
MaximilianFT 3986218
Apply suggestion from @deboragracio
MaximilianFT e6bef63
Apply suggestion from @deboragracio
MaximilianFT 5e07d13
Apply suggestion from @deboragracio
MaximilianFT 86a104f
Apply suggestion from @deboragracio
MaximilianFT b82d171
Apply suggestion from @deboragracio
MaximilianFT 9f0d017
Apply suggestion from @deboragracio
MaximilianFT 7921526
Apply suggestion from @deboragracio
MaximilianFT be8a162
Apply suggestion from @deboragracio
MaximilianFT 248ee4d
Apply suggestion from @deboragracio
MaximilianFT 1927ade
Apply suggestion from @deboragracio
MaximilianFT cc431ed
Apply suggestion from @deboragracio
MaximilianFT 386ccd0
Apply suggestion from @deboragracio
MaximilianFT 13bafb1
Apply suggestion from @deboragracio
MaximilianFT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,3 +25,22 @@ Several critical error scenarios must be managed carefully to prevent double pay | |
| - The response is not received within the expected time frame (HTTP timeout), which can be simulated by a device losing internet connectivity during payment execution. | ||
|
|
||
| In all of these cases, the solution is to resend the original request using the identical operation ID and request body. The backend will then return the final result of the operation. | ||
|
|
||
| ## Special case - payment vendor added TIP | ||
|
|
||
| In many payment vendor apps it is possible to add a tip to the payment amount. | ||
| Flow example in a restaruant: | ||
|
turtletramp marked this conversation as resolved.
Outdated
|
||
| - Guest asks for the bill | ||
|
MaximilianFT marked this conversation as resolved.
Outdated
|
||
| - Waiter triggers to create the bill at the POS (e.g. mobile device) | ||
|
MaximilianFT marked this conversation as resolved.
Outdated
|
||
| - The POS on the mobile device pushes the amount (for example 10€) to be paid to the configured payment app (via POS System API and the fiskaltrust InStore App) | ||
|
MaximilianFT marked this conversation as resolved.
Outdated
|
||
| - The payment app opens and the waiter hands the mobile device over to the guest | ||
|
MaximilianFT marked this conversation as resolved.
Outdated
|
||
| - The guest sees a TIP entry screen and adds a tip of 2€ | ||
|
MaximilianFT marked this conversation as resolved.
Outdated
|
||
| - The guests now pays the full sum of 12€ | ||
|
MaximilianFT marked this conversation as resolved.
Outdated
|
||
| - The payment app reports a paid amount of 12€ (including 2€ of tip) | ||
|
MaximilianFT marked this conversation as resolved.
Outdated
|
||
| - The fiskaltrust InStore App / POS System API does report back the following in the payment response (see also example in the POS System API docs): | ||
|
MaximilianFT marked this conversation as resolved.
Outdated
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should a hyperlink be added to: (see also an example on the POS System API docs)? |
||
| - 2 pay items | ||
| - Pay item 1: The fully paid amount with the receipt -> 12€ | ||
|
MaximilianFT marked this conversation as resolved.
Outdated
|
||
| - Pay item 2: The tip with negative amount -> -2€ | ||
|
MaximilianFT marked this conversation as resolved.
Outdated
|
||
| - sum of the 2 pay items is the orginal requested amount of 10€ | ||
|
turtletramp marked this conversation as resolved.
Outdated
|
||
|
|
||
| NOTE: The tip can be calculated by simply substracting the requested amount from the paid amount (12-10 = 2€ tip) or alternatively from the 2nd pay item (-2 * -1 = 2€ tip). | ||
|
turtletramp marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.