Skip to content

Add memory provider#11

Closed
fivetran-davefowler wants to merge 2 commits into
mainfrom
notes_provider
Closed

Add memory provider#11
fivetran-davefowler wants to merge 2 commits into
mainfrom
notes_provider

Conversation

@fivetran-davefowler
Copy link
Copy Markdown

@fivetran-davefowler fivetran-davefowler commented May 31, 2026

Summary

Adds a tool-agnostic memory provider for durable agent-facing data semantics.

  • Adds agents-schema memory --memory-file memory.yml
  • Writes AGENTS.MEMORY and AGENTS.MEMORY_ANCHOR
  • Registers the memory provider in AGENTS.ROOT
  • Keeps the core schema small: memory id/kind/title/content/source/confidence plus anchors for table, column, relationship, and metric retrieval
  • Does not repeat a row-level provider in AGENTS.MEMORY; the table family is already the memory provider, and multi-tool provenance belongs in source
  • Documents memory as an aggregator/summarizer layer over richer providers like LookML, dbt, OSI, catalogs, and reviewed agent discoveries
  • Documents canonical YAML plus a compact project memories.yaml authoring shape that maps into the canonical tables
  • Adds a Mermaid schema DAG for the memory tables and anchor targets
  • Validates YAML strictly: unknown fields, bad scalar types, duplicate memories, duplicate anchors, invalid anchor types, and missing locators fail fast

Review

Dataface reviewer pass: APPROVED before the later schema simplification. The latest change is a narrower schema shape and passing tests.

Verification

uv run python -m unittest discover -s tests
Ran 18 tests
OK

git diff --check

@fivetran-davefowler fivetran-davefowler force-pushed the notes_provider branch 3 times, most recently from 6729a6c to add492a Compare May 31, 2026 04:36
…, OSI framing

- confidence is now FLOAT in [0,1] (was free-form varchar) so consumers can threshold/rank
- relationship anchors carry the join inline via from_*/to_* (+ paired array columns)
  instead of a single-table locator; relationship_name is an optional, unenforced
  pointer to OSI_RELATIONSHIP when present
- tighten anchor validation: reject locator columns that don't belong to the anchor type
- document when to use memory and that OSI-native teams should prefer object-local
  ai_context (memory is the no-semantic-layer path)
- add agents-schema-memory workflow + composite action + memory-setup.md to match
  the other providers; link from README
- follow OSI parent/child key convention (documented in code + SPEC)
- fix memory_path variable shadowing

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@fivetran-davefowler
Copy link
Copy Markdown
Author

Superseded by #13 — the notes_provider branch was renamed to memory-provider, which closed this PR. #13 has the same work plus the review refinements (float confidence, inline relationship anchors, OSI ai_context framing, tighter validation, and the missing workflow/setup files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant