Skip to content

fix: add a defence for Path Traversal #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DuLinRain wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add a defence for Path Traversal #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {readFile} from 'fs'
import http from 'http'
import https from 'https'
import {resolve} from 'path'
import {resolve, posix} from 'path'

import mime from 'mime'
import opener from 'opener'
Expand Down Expand Up @@ -84,7 +84,10 @@ export default function server(options = {contentBase: ''}) {
});

// Remove querystring
const urlPath = decodeURI(request.url.split('?')[0])
const unsafePath = decodeURI(request.url.split('?')[0])

// Don't allow path traversal
const urlPath = posix.normalize(unsafePath)

readFileFromContentBase(options.contentBase, urlPath, function (error, content, filePath) {

Expand Down