Support pandas 2/3, modern websockets, and Python 3.12+ - #30
Merged
Conversation
Relax the dependency pins that blocked running alongside a pandas-2 stack (loica): pandas>=2.0, numpy>=1.26, scipy>=1.11, websockets>=12, and widen requires-python to >=3.9. Drop the redundant asyncio backport pin, which does not install on modern Python. Fix the pandas-2 breakages this surfaces in the client: - _analysis concatenates result chunks with pd.concat (DataFrame.append was removed in pandas 2). - _measurements and _analysis wrap raw JSON in io.StringIO before pd.read_json, which otherwise treats the string as a file path. Pass an int max_size to websockets.connect; a float tripped the permessage-deflate decompressor on compressed frames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax the dependency pins that blocked running alongside a pandas-2 stack (pandas>=2.0, numpy>=1.26, scipy>=1.11, websockets>=12), and widen requires-python to >=3.9. Drop the redundant asyncio backport pin, which does not install on modern Python.
Both PRs for this repo (#25 and #27) won't be necessary if we only pin major and minor versions (see here for more info on semantic versioning).