Skip to content

Setup experience software is installed on iOS/iPadOS hosts (any enrollment method)#48618

Open
noahtalerman wants to merge 12 commits into
mainfrom
noahtalerman-patch-79
Open

Setup experience software is installed on iOS/iPadOS hosts (any enrollment method)#48618
noahtalerman wants to merge 12 commits into
mainfrom
noahtalerman-patch-79

Conversation

@noahtalerman

@noahtalerman noahtalerman commented Jul 2, 2026

Copy link
Copy Markdown
Member
  • QA'd all new/changed functionality manually

  • Enrollment methods: ADE, profile-based manual, Managed Apple Account

  • Also, update Controls > Setup experience copy. "Automatically" only applies to macOS:

Screenshot 2026-07-02 at 9 41 17 AM
  • Every other platform:
Screenshot 2026-07-02 at 9 41 31 AM

Summary by CodeRabbit

  • Bug Fixes
    • Updated the setup guidance text for platform-specific enrollment so macOS now shows a distinct message.
    • Other platforms continue to display the standard enrollment wording, improving clarity in the install experience.

noahtalerman and others added 8 commits March 26, 2026 15:57
Currently, Fleet doesn't support CVEs for Debian or Fedora packages. OS (kernel CVEs) are supported
Best practice is to create an API-only user w/ the admin role and access only to necessary SCIM API endpoints
- These doc updates require [this bug](#48062) to be fixed because the `/scim/*` API endpoints aren't exposed as API endpoints one can pick when creating an API only user
  -  Separate PR to add them to the API docs: TODO
…lment method)

- Enrollment methods: ADE, profile-based manual, Managed Apple Account
Comment thread articles/role-based-access.md Outdated
Comment thread articles/role-based-access.md Outdated
@noahtalerman noahtalerman marked this pull request as ready for review July 2, 2026 13:42
@noahtalerman noahtalerman requested a review from a team as a code owner July 2, 2026 13:42

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c0b94b9f-4f25-4dff-9716-66d676260a28

📥 Commits

Reviewing files that changed from the base of the PR and between 7023c5b and c709d4b.

⛔ Files ignored due to path filters (1)
  • articles/setup-experience.md is excluded by !**/*.md
📒 Files selected for processing (1)
  • frontend/pages/ManageControlsPage/SetupExperience/cards/InstallSoftware/InstallSoftware.tsx

Walkthrough

Changes

The change modifies the platform condition used to select the description text shown for the Install Software card's enrollment message. Previously, Windows and Linux platforms displayed "enroll to Fleet" while other platforms defaulted to "automatically enroll to Fleet". The condition now checks specifically for macOS to display "automatically enroll to Fleet", with all other platforms showing "enroll to Fleet".

Related PRs: None identified.

Suggested labels: frontend, bug

Suggested reviewers: None identified.

Poem
A rabbit hopped through platform code,
Swapped macOS onto a different road,
Enroll or auto-enroll, the message shifts,
One line changed, three small gifts,
Hop, hop, the build compiles clean and light.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is specific and aligned with the PR’s main goal of extending software installation to iOS/iPadOS hosts across enrollment methods.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch noahtalerman-patch-79

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant