Skip to content

Feature/network#293

Merged
FBumann merged 24 commits into
mainfrom
feature/network
Sep 2, 2025
Merged

Feature/network#293
FBumann merged 24 commits into
mainfrom
feature/network

Conversation

@FBumann
Copy link
Copy Markdown
Member

@FBumann FBumann commented Aug 8, 2025

Description

This adds n interactive Dash App to visualize the FlowSystem as a Network.
It can be called through

flow_system.start_network_app()

The app runs in the background and can be stopped manually.

flow_system.stop_network_app()

There is lots of room for improvement, but its already much better than the pyvis version in my opinion.

Lets discuss needed improvements and wether we can remove the pyvis version in favor of this one. (Maybe deprecate it first)

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring

Related Issues

Testing

  • I have tested my changes
  • Existing tests still pass

Checklist

  • My code follows the project style
  • I have updated documentation if needed
  • I have added tests for new functionality (if applicable)

@FBumann FBumann requested review from PStange and baumbude August 8, 2025 16:22
@FBumann FBumann added the New functionality Add entirely new functionality label Aug 8, 2025
@FBumann
Copy link
Copy Markdown
Member Author

FBumann commented Aug 14, 2025

Plotting the network with pyvis could be deprecated later on if this new way works out to be the better option

@FBumann
Copy link
Copy Markdown
Member Author

FBumann commented Sep 2, 2025

@PStange Hast du hierzu Rückmeldung?
Vllt auch von deinem Kollegen?

@PStange
Copy link
Copy Markdown
Collaborator

PStange commented Sep 2, 2025

Nein, er ist gerade länger im Urlaub. Sah doch aber gut aus.

@FBumann
Copy link
Copy Markdown
Member Author

FBumann commented Sep 2, 2025

@baumbude Hast du Feedback?
Ich würde das aber so oder so mal merged.
Spricht nichts dagegen finde ich (der Test issue liegt an der neuen linopy Version , fixe ich noch)

@baumbude
Copy link
Copy Markdown
Collaborator

baumbude commented Sep 2, 2025 via email

@FBumann FBumann merged commit f81975a into main Sep 2, 2025
9 checks passed
@FBumann FBumann deleted the feature/network branch September 2, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New functionality Add entirely new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants