Skip to content

Fix approvals feedback and notifications#2240

Merged
federicodeponte merged 1 commit into
mainfrom
fix/approval-experience-logos-emails
Jul 12, 2026
Merged

Fix approvals feedback and notifications#2240
federicodeponte merged 1 commit into
mainfrom
fix/approval-experience-logos-emails

Conversation

@federicodeponte

Copy link
Copy Markdown
Member

Summary

  • Upstream DocuSign into the engine-owned BrandLogo/IconSprite pair so cloud does not need a brand-logo overlay fork for shared worker cards.
  • On approval rejection with reviewer feedback, queue a normal retry of the same worker with _workeros_review_feedback and retry_of_run_id linking it to the original run.
  • Add pending-approval email notifications to configured worker alert recipients with signed review links, using the existing alert throttle store and WORKEROS_EMAIL_FROM sender precedence.

Validation

  • python3 -m pytest ../../tests/test_418_approval_gate.py tests/test_approval_decision_toctou_280.py tests/test_l3_run_email_summary.py tests/test_alert_email_throttle.py -q
  • npm test -- --run tests/worker-flow-brand-logo.dom.test.tsx
  • npm run lint:emdash
  • gitleaks detect on the explicit origin/main..HEAD range

@federicodeponte federicodeponte marked this pull request as ready for review July 10, 2026 16:38
@federicodeponte federicodeponte force-pushed the fix/approval-experience-logos-emails branch from 3a6a8e9 to cedbc1e Compare July 12, 2026 12:05
@federicodeponte federicodeponte merged commit 3eab174 into main Jul 12, 2026
7 checks passed
@federicodeponte federicodeponte deleted the fix/approval-experience-logos-emails branch July 12, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant