Repository navigation
Welcome buttons open on the first click when their menu is open - #65
Merged
flowtricks merged 1 commit intoOct 28, 2026
Merged
Conversation
With a split button's menu open, a click on its main half only closed the menu, because the popup treated it as an outside press and swallowed it. Popup now takes an optional within element whose presses are not outside presses, and the split button passes its whole group, so one click closes the menu and runs the main action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a split button's menu open, a click on its main half only closed the menu, because the popup treated it as an outside press and swallowed it. Popup now takes an optional within element whose presses are not outside presses, and the split button passes its whole group, so one click closes the menu and runs the main action.