Skip to content

Add CloudFront signer package#211

Merged
floydspace merged 3 commits into
floydspace:mainfrom
yotamishak:add-cloudfront-signer
May 12, 2026
Merged

Add CloudFront signer package#211
floydspace merged 3 commits into
floydspace:mainfrom
yotamishak:add-cloudfront-signer

Conversation

@yotamishak

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented Apr 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1ad377e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect-aws/cloudfront Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AsafBenjaminov

Copy link
Copy Markdown

lgtm

@floydspace

Copy link
Copy Markdown
Owner

Hi @yotamishak thanks for contribution, I will carefully review it this week.

@floydspace floydspace left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yotamishak
checked the code, and I have a change request for you:
could you pls make the more general @effect-aws/cloudfront package which will contain signer module, similar how it is done in dslq. The idea is to have aws service specific package with different utilities, this one will be a new cloudfront package
That is my oppinioated preferrence how to organize code, but I think it makes sense. I done want to make too many specific packages, in spite aws itself does

@floydspace

Copy link
Copy Markdown
Owner

and pls rebase, I updated the lock file

@yotamishak yotamishak force-pushed the add-cloudfront-signer branch from 2499c0c to 1ad377e Compare May 12, 2026 10:13
@yotamishak

Copy link
Copy Markdown
Contributor Author

@floydspace done, lemme know if you want me to update the https://effect-aws.website/docs/ as well

@floydspace floydspace merged commit 3cd967f into floydspace:main May 12, 2026
7 checks passed
@github-actions github-actions Bot mentioned this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants