Repository navigation
feat(helm): add excludePath to fluentbit tail input - #2074
Merged
Merged
Conversation
fix: fluent#2073 Signed-off-by: Mikael Loaec <17707793+miloaec@users.noreply.github.com>
joshuabaird
reviewed
Oct 22, 2026
Comment on lines
+15
to
+17
| {{- if eq .Values.fluentbit.input.tail.excludePath }} | ||
| excludePath: {{ .Values.fluentbit.input.tail.excludePath | quote }} | ||
| {{- end }} |
Collaborator
There was a problem hiding this comment.
Thanks for the PR! This template doesn't render as written. eq needs two arguments, which is why lint-test fails:
error calling eq: missing argument for comparison
Could you switch to with, matching the other optional fields in this template?
Suggested change
| {{- if eq .Values.fluentbit.input.tail.excludePath }} | |
| excludePath: {{ .Values.fluentbit.input.tail.excludePath | quote }} | |
| {{- end }} | |
| {{- with .Values.fluentbit.input.tail.excludePath }} | |
| excludePath: {{ . | quote }} | |
| {{- end }} |
Contributor
Author
There was a problem hiding this comment.
Thanks for help 🙏
Fixed 😄
joshuabaird
changed the title
Signed-off-by: Mikael Loaec <17707793+miloaec@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2073
Signed-off-by: Mikael Loaec 17707793+miloaec@users.noreply.github.com