Repository navigation
Conversation
Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
…ption Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds an optional
compressfield to the Fluent Bitforwardoutput (ClusterOutput and Output). It's rendered as Fluent Bit'sCompressoption, so data sent to Fluentd or another Fluent Bit can be gzip-compressed. The field is validated as an enum with the one value Fluent Bit supports,gzip. The description carries the limits from the Fluent Bit docs: it's incompatible withtimeAsInteger: trueand with tags set by the Rewrite Tag filter, and it needs Fluentd v0.14.7 or later.When the field isn't set nothing is rendered, so existing configs are unchanged.
Which issue(s) this PR fixes:
Fixes #1492
Does this PR introduced a user-facing change?
Notes
#1493 added this earlier but was closed for inactivity after DCO problems, so I picked it up.
This time I ran the generators instead of editing generated files by hand:
make generate manifests docs-update, in WSL with controller-gen v0.18.0 from the Makefile. That updated only the outputs CRDs (config, both charts,manifests/setup/setup.yaml) anddocs/plugins/fluentbit/output/forward.md.Tested locally:
go test ./apis/...passes, including the newTestOutput_Forward_Paramscases (with and withoutcompress), andmake lintreports0 issues.