Repository navigation
Conversation
Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
…etrics flush interval Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the
flushIntervalSecandflushIntervalNsecoptions to the Fluent BitlogToMetricsfilter (ClusterFilter and Filter). They're rendered as Fluent Bit'sFlush_Interval_SecandFlush_Interval_Nsec.Without them, the filter emits metrics right after every matching record. #1459 reports this produces duplicate samples with the same timestamp and different values in Prometheus. With an interval set, metrics are emitted once per interval, which also lowers resource use under load.
Both fields are optional and validated as non-negative (
flushIntervalNsecup to 999999999). When they aren't set nothing is rendered, so existing configs are unchanged.Which issue(s) this PR fixes:
Fixes #1459
Does this PR introduced a user-facing change?
Notes
I ran the generators (
make generate manifests docs-update, in WSL with controller-gen v0.18.0) rather than editing generated files by hand. They updated the filter deepcopy, the filters CRDs (config, both charts,manifests/setup/setup.yaml) anddocs/plugins/fluentbit/filter/log_to_metrics.md.Tested locally:
go test ./apis/...passes, including the newTestFilter_LogToMetrics_*cases (with and without the interval), andmake lintreports0 issues.