Skip to content

fix(in_tail): fix variable name bugs causing position file leak and NameError #5441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
magic-peach wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix(in_tail): fix variable name bugs causing position file leak and NameError #5441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/fluent/plugin/in_tail.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ def detach_watcher(tw, ino, close_io = true)

tw.close if close_io

if @pf && tw.unwatched && (@follow_inode || !@tails[tw.path])
if @pf && tw.unwatched && (@follow_inodes || !@tails[tw.path])
target_info = TargetInfo.new(tw.path, ino)
@pf.unwatch(target_info)
end
Expand Down Expand Up @@ -751,7 +751,7 @@ def convert_line_to_event(line, es, tail_watcher)
else
if @emit_unmatched_lines
record = {'unmatched_line' => line}
record[@path_key] ||= tail_watcher.path unless @path_key.nil?
record[@path_key] ||= tw.path unless @path_key.nil?

@Watson1978 Watson1978 Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks inverted. In convert_line_to_event(line, es, tail_watcher) the parameter is named tail_watcher, and tw is not in scope here (the block parameters are |time, record|). So tw.path raises NameError: undefined local variable or method 'tw' whenever this branch runs (emit_unmatched_lines enabled with path_key).

es.add(Fluent::EventTime.now, record)
end
log.warn { "pattern not matched: #{line.inspect}" }
Expand Down
Loading