properly handle deleting sha from query parameters#5009
properly handle deleting sha from query parameters#5009auto-submit[bot] merged 4 commits intomainfrom
Conversation
|
🤖 Hi @ievdokdm, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The Pull Request successfully addresses the issue of properly handling the deletion of the SHA from query parameters in the dashboard. The introduction of asynchronous logic and the reset of internal state ensure that the latest SHA is correctly picked when the user removes the parameter from the URL.
🔍 General Feedback
- The change to make many
PresubmitStatemethodsasyncand returnFuture<void>is consistent and well-applied across both the main code and the tests. - However, there are a few places where
awaitmight be over-applied, potentially causing unnecessary UI delays or misleading loading indicators (e.g., when filtering or fetching summaries). Reverting those tounawaitedwould improve the user experience while maintaining the correctness of the state updates. - Overall, the logic is sound and the added tests adequately cover the new behavior.
ievdokdm
added
the
autosubmit
|
auto label is removed for flutter/cocoon/5009, Failed to merge flutter/cocoon/5009 with Pull request flutter/cocoon/5009 could not be merged: Required status check "ci.yaml validation" is expected.. |
auto-submit
bot
removed
the
autosubmit
ievdokdm
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/cocoon/5009, Failed to merge flutter/cocoon/5009 with Pull request flutter/cocoon/5009 could not be merged: Required status check "ci.yaml validation" is expected.. |
ievdokdm
added
autosubmit
2 participants
Fix: flutter/flutter#184372