Prevent GC of value during async eval#9885
Open
srawlins wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes garbage collection issues with the result list in asyncEval on both native VM and web by keeping a strong reference to the reader object in the target app until the future resolves. The reviewer pointed out that using Timer.periodic inside the evaluated expression might fail if the target library does not explicitly import dart:async. They suggested using an asynchronous loop with Future.delayed instead, as Future is part of dart:core and guaranteed to be available in any Dart library context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gemini suggests this to reduce flakiness in integration tests, some of which strongly rely on eval. Gemini looked at recent failed integration tests to suggest this.