Skip to content

Move all prompts to .agents/ and point to agents from claude, gemini#9034

Merged
helin24 merged 4 commits into
flutter:mainfrom
helin24:remove-prompts
Jul 10, 2026
Merged

Move all prompts to .agents/ and point to agents from claude, gemini#9034
helin24 merged 4 commits into
flutter:mainfrom
helin24:remove-prompts

Conversation

@helin24

@helin24 helin24 commented Jul 9, 2026

Copy link
Copy Markdown
Member

While working on another skill, gemini was trying to add a skill both to .agents/skills and also to the prompts file. I think the prompts file is less useful now that skills are an accepted strategy, so I copied all the prompts to separate skills.

It sounds like gemini and claude should be able to find .agent/skills but this may vary by version; hopefully adding a note about the presence of "agent-agnostic" skills will do the right thing.

@helin24
helin24 requested review from pq and removed request for pq July 9, 2026 17:06

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the AI agent instructions by migrating the monolithic prompt file into modular, executable skill files under .agents/skills/ and updating CLAUDE.md to reference these new workflows. Feedback is provided regarding the accidental removal of the "Zero-Formatting Policy" from CLAUDE.md, which is a core style guide rule and should be restored.

Comment thread CLAUDE.md
@helin24
helin24 requested a review from pq July 9, 2026 17:24
@helin24

helin24 commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

CC @jwren

@pq

pq commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Cool!

I do wonder if we shouldn't do a review of these before we move them all to skills (which I think kind of blesses them).

For example:

  • update-intellij-platform-plugin -- now that we have dependabot in play, I'm not sure we need this?
  • improve-documentation-coverage -- we haven't really prioritized API docs and I'm not sure we ever will; so maybe this is distracting?
  • optimize-gradle-build -- aren't we done here? I'm not sure we want to skillify it, regardless.
  • audit-accessibility -- I love this but think we should have a plan and commitment to accessibility first

I'd be interested to get @jwren's 2 cents!

@helin24

helin24 commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

Here is gemini's recommendation on what to remove/keep also:

Here is a critical audit of the 17 skills currently in  .agents/skills/ .

  Many of these originated as generic prompt ideas and can be safely removed because they either repeat standard AI behavior, overlap with automated bots, or duplicate other skills.
  ──────
  ### 1. Recommended for Removal (Low-Value / Generic / Obsolete)

   Skill                             | Why It Should Be Removed
  -----------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    update-intellij-platform-plugin  | As Phil noted, updating the  org.jetbrains.intellij.platform  Gradle plugin version is a 1-line bump ( third_party/build.gradle.kts ) typically handled automatically by Dependabot/Renovate or done
                                     | manually in seconds.
    optimize-gradle-build            | Running  --profile  and enabling Gradle caching ( org.gradle.caching=true ) is generic Gradle advice and a rare one-off infrastructure task rather than a repeatable daily workflow.
    fix-specified-issue              | Tells the agent to "take a GitHub issue/stack trace, reproduce it, fix it, run  ./gradlew test , and write a test." That is already the default behavior of any AI coding assistant when asked to fix an
                                     | issue.
    prepare-pr-cleanup               | Generic pre-PR hygiene ("run  ./gradlew test , remove  System.out.println  and unused imports"). Standard IDE linting and CI presubmits enforce this without needing a specialized agent skill.
    improve-documentation-coverage   | Generic instructions ("pick 5 files and add standard Javadoc/KDoc"). Any agent already knows how to write Javadoc when asked "Add Javadocs to class X".
  ──────
  ### 2. Recommended for Consolidation (Duplicative)

   Skill                                                      | Why Consolidate
  ------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    improve-single-file-coverage (vs  add-missing-unit-test ) | Both skills describe the exact same workflow ( ./gradlew testClasses , run Kover report, write JUnit test in  testSrc/ , verify Kover delta). We should keep  add-missing-unit-
                                                              | test  (or rename to  improve-unit-test-coverage ) and delete  improve-single-file-coverage .
  ──────
  ### 3. Recommended to Keep (High-Value / Domain-Specific)

   Skill                                          | Why Keep
  ------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    remove-platform-version                       | Highly specific to  flutter-intellij  multi-platform architecture ( sinceBuild  in  gradle.properties , CI verifier loops in  tool/github.sh , deleting baseline files in  tool/baseline/ ).
    resolve-verification-issues 		  | Specific to  ./gradlew verifyPlugin  output, binary compatibility baselines, and IntelliJ Platform API usage rules (Internal/Override-only APIs).
    verify-eap-compatibility                      | Essential for testing JetBrains Early Access Program (EAP) releases and managing  since-build / until-build  bounds in  plugin.xml .
    audit-ui-thread-safety                        | Crucial for IntelliJ Platform UI responsiveness (enforcing Event Dispatch Thread / EDT rules, offloading I/O to background tasks, and non-blocking read actions).
    migrate-intellij-util                         | Guides AI agents to use specialized IntelliJ memory-optimized collections and utilities ( SmartList ,  ContainerUtil ,  StringUtil ,  Alarm ) instead of generic Java APIs ( ArrayList ,
                                                  | HashMap ).
    code-review                                   | Enforces the repository's strict review guidelines (zero-formatting noise, structured  [MUST-FIX] / [CONCERN] / [NIT]  tags, and shell script efficiency rules).
    cleanup-code-inspections                      | Specific to resolving or cleanly suppressing ( //noinspection ) static analysis warnings from IntelliJ's inspection engine.
    audit-accessibility                           | Enforces Swing/IntelliJ accessibility rules ( setAccessibleName ,  setAccessibleDescription , focus traversal on custom  JPanel / Dialog ).
    cleanup-unused-assets  /  audit-dependencies  | Domain-specific cleanup for  resources/icons  and  plugin.xml   <depends>  tags.
  ──────
  ### Summary Recommendation

  By deleting the 6 low-value / redundant skills ( update-intellij-platform-plugin ,  optimize-gradle-build ,  fix-specified-issue ,  prepare-pr-cleanup ,  improve-documentation-coverage , and  improve-single-file-coverage ), we reduce the
  skill set from 17 down to 11 highly focused, domain-specific skills.

I think we can go ahead and be aggressive about deleting since these will not be hard to get back if we need them.

@pq

pq commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

I think we can go ahead and be aggressive about deleting since these will not be hard to get back if we need them.

💯

Thanks!

@helin24

helin24 commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

Updated - I'm keeping the accessibility one; I'm not sure what we want to do there, but this may be a good project for our new contributors to consider.

@helin24
helin24 merged commit 61b665d into flutter:main Jul 10, 2026
14 checks passed
@helin24
helin24 deleted the remove-prompts branch July 10, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants