[material_ui, cupertino_ui] Add `#region` to example files to remove license headers by dkwingsmt · Pull Request #12170 · flutter/packages

dkwingsmt · 2026-07-09T23:45:01Z

This PR adds #region to example files to remove the license headers.

Before:

After:

Verification

I have audited all example files to ensure every file belongs to one of the following types:

Referenced in material_ui or cupertino_ui: These have been updated in this PR to include the #region tags.
Not referenced and not for a Material/Cupertino widget: These files have been removed in PR [material_ui] Remove unused example files #12179.
Not referenced but for a Material/Cupertino widget: The following two files remain, and we should consider adding them to the respective API documentation in the future:

material_ui/example/lib/selection_area/selection_area.1.dart
material_ui/example/lib/selection_area/selection_area.2.dart

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

gemini-code-assist

Code Review

This pull request introduces // #region body and // #endregion body tags to example files in both cupertino_ui and material_ui packages, and updates example references in cupertino_ui source files to target the #body region. Feedback indicates that several material_ui example files are missing the opening // #region body tag, and the corresponding material_ui library source files have not been updated to append #body to their example references.

dkwingsmt · 2026-07-10T17:53:39Z

Thanks for reviewing. Some of the files need extra treatment before this PR can be merged. For example, some files correspond to widgets defined in flutter/widgets, so these files should be moved instead of changed here. I'll review them before requesting for another review.

Piinks · 2026-07-10T17:57:03Z

Some of the files need extra treatment before this PR can be merged. For example, some files correspond to widgets defined in flutter/widgets, so these files should be moved instead of changed here.

What do you mean? It is ok to have an example copied over from widgets/ for use in the API docs here. We just moved some of those samples over last week.

dkwingsmt · 2026-07-10T19:53:10Z

@Piinks Most files mentioned above are not referenced in material_ui at all. They're testing widgets defined in flutter/widgets and are referred to only by widgets in flutter/widgets. They should totally reside in flutter/widgets.

dkwingsmt · 2026-07-13T05:19:17Z

This PR is ready for another round of review.

I have audited all example files to ensure every file belongs to one of the following types:

Referenced in material_ui or cupertino_ui: These have been updated in this PR to include the #region tags.
Not referenced and not for a Material/Cupertino widget: These files have been removed in PR [material_ui] Remove unused example files #12179.
Not referenced but for a Material/Cupertino widget: The following two files remain, and we should consider adding them to the respective API documentation in the future:

material_ui/example/lib/selection_area/selection_area.1.dart
material_ui/example/lib/selection_area/selection_area.2.dart

dkwingsmt · 2026-07-13T05:19:26Z

/gemini review

gemini-code-assist

Code Review

This pull request updates numerous example files across the cupertino_ui and material_ui packages to wrap code samples with // #region body and // #endregion body comments, while updating corresponding documentation references to target the #body suffix. However, several files in the material_ui package add the closing // #endregion body tag without the matching opening // #region body tag at the top of the file.

gemini-code-assist · 2026-07-13T05:27:38Z

    );
  }
 }
+// #endregion body


The closing tag // #endregion body is added here, but the matching opening tag // #region body is missing at the top of the file. Please add // #region body right after the license header at the top of the file so that the region is correctly defined.

gemini-code-assist · 2026-07-13T05:27:38Z

    );
  }
 }
+// #endregion body


The closing tag // #endregion body is added here, but the matching opening tag // #region body is missing at the top of the file. Please add // #region body right after the license header at the top of the file so that the region is correctly defined.

gemini-code-assist · 2026-07-13T05:27:38Z

    r'(?<topLevelDomain>[a-zA-Z0-9]+)',
  ).hasMatch(text);
 }
+// #endregion body


The closing tag // #endregion body is added here, but the matching opening tag // #region body is missing at the top of the file. Please add // #region body right after the license header at the top of the file so that the region is correctly defined.

gemini-code-assist · 2026-07-13T05:27:38Z

    );
  }
 }
+// #endregion body


The closing tag // #endregion body is added here, but the matching opening tag // #region body is missing at the top of the file. Please add // #region body right after the license header at the top of the file so that the region is correctly defined.

gemini-code-assist

Code Review

This pull request updates example files across the cupertino_ui and material_ui packages to define code regions using // #region body and // #endregion body tags, while updating the source file documentation references to target these specific regions. Feedback indicates that several example files are missing the corresponding // #region body tag at the top of the file, despite having the // #endregion body tag added at the end.

gemini-code-assist · 2026-07-13T05:35:59Z

    );
  }
 }
+// #endregion body


This file has // #endregion body added at the end, but is missing the corresponding // #region body at the top of the file. Please add // #region body at the top of the file (typically right after the imports) to correctly define the region.

gemini-code-assist · 2026-07-13T05:35:59Z

    );
  }
 }
+// #endregion body


This file has // #endregion body added at the end, but is missing the corresponding // #region body at the top of the file. Please add // #region body at the top of the file (typically right after the imports) to correctly define the region.

gemini-code-assist · 2026-07-13T05:35:59Z

    r'(?<topLevelDomain>[a-zA-Z0-9]+)',
  ).hasMatch(text);
 }
+// #endregion body


This file has // #endregion body added at the end, but is missing the corresponding // #region body at the top of the file. Please add // #region body at the top of the file (typically right after the imports) to correctly define the region.

gemini-code-assist · 2026-07-13T05:35:59Z

    );
  }
 }
+// #endregion body


This file has // #endregion body added at the end, but is missing the corresponding // #region body at the top of the file. Please add // #region body at the top of the file (typically right after the imports) to correctly define the region.

dkwingsmt added 4 commits July 9, 2026 16:26

Add starting region

da87c0e

Add end region

53e4a04

Add #body to directives

2f4d083

Fix more starting

2532b18

flutter-dashboard Bot added the CICD Run CI/CD label Jul 9, 2026

github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui p: material_ui labels Jul 9, 2026

gemini-code-assist Bot reviewed Jul 9, 2026

View reviewed changes

dkwingsmt marked this pull request as draft July 10, 2026 17:53

dkwingsmt added 2 commits July 12, 2026 22:03

Merge remote-tracking branch 'origin/main' into example-region

53f050d

Revert some files

4c84ddb

github-actions Bot removed the CICD Run CI/CD label Jul 13, 2026

dkwingsmt marked this pull request as ready for review July 13, 2026 05:18

dkwingsmt added the CICD Run CI/CD label Jul 13, 2026

dkwingsmt requested a review from Piinks July 13, 2026 05:19

gemini-code-assist Bot reviewed Jul 13, 2026

View reviewed changes

Uh oh!

Conversation

dkwingsmt commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Verification

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dkwingsmt commented Jul 10, 2026

Uh oh!

Piinks commented Jul 10, 2026

Uh oh!

dkwingsmt commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkwingsmt commented Jul 13, 2026

Uh oh!

dkwingsmt commented Jul 13, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dkwingsmt commented Jul 9, 2026 •

edited

Loading

dkwingsmt commented Jul 10, 2026 •

edited

Loading