Skip to content

[go_router_builder] Support analyzer 13#12189

Open
simolus3 wants to merge 2 commits into
flutter:mainfrom
simolus3:go-router-analyzer-13
Open

[go_router_builder] Support analyzer 13#12189
simolus3 wants to merge 2 commits into
flutter:mainfrom
simolus3:go-router-analyzer-13

Conversation

@simolus3

@simolus3 simolus3 commented Jul 12, 2026

Copy link
Copy Markdown

This declares support for analyzer versions 13.x in the go_router_builder package.

I ran tool/run_tests.dart after upgrading, no code changes are necessary and existing tests pass. Note that another package in this repository, pigeon, also depends on an older analyzer version but would require code changes to support analyzer version 13.x.

Closes flutter/flutter#189357.

Pre-Review Checklist

Comments below:

  • There is no relevant documentation to update.
  • This change is covered by existing tests, so I have not added new ones.

@github-actions github-actions Bot added p: go_router_builder triage-framework Should be looked at in framework triage labels Jul 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the analyzer dependency constraint in packages/go_router_builder/pubspec.yaml to support version 13 (allowing <14.0.0) and updates the CHANGELOG.md accordingly. There are no review comments, and I have no feedback to provide.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Thank you for your contribution! Because of the volume of PRs we receive, we require that new contributors use our checklist to guide them through critical steps in creating a Flutter PR. This PR's description is missing that checklist, so it is being marked as a Draft.

Please edit the PR description to add the checklist, then ensure that you have completed all of the steps. Once you've done that, please mark the PR as ready for review.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft July 12, 2026 22:02
@simolus3 simolus3 marked this pull request as ready for review July 13, 2026 06:41

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the go_router_builder package to version 4.3.1, extending the supported range of the analyzer dependency to <14.0.0 and updating the changelog accordingly. There are no review comments, and I have no feedback to provide.

@simolus3

Copy link
Copy Markdown
Author

Apologies for causing extra work here, I assumed it would be fine for a tiny change but I shouldn't have skipped that. I have created an issue and filled out the checklist now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: go_router_builder triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[go_router_builder] Support analyzer versions 13.x

2 participants