Skip to content

test(connectivity_plus): update android version boundary to accommodate API 24 emulator behavior #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdmahendri wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

test(connectivity_plus): update android version boundary to accommodate API 24 emulator behavior #3857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .../connectivity_plus/connectivity_plus/example/integration_test/connectivity_plus_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,23 +22,23 @@ void main() {
expect(result, isNotNull);
});

testWidgets('connectivity on Android newer than 5 (API 21) should be wifi',
testWidgets('connectivity on Android newer than 7 (API 24) should be wifi',
(WidgetTester tester) async {
final result = await connectivity.checkConnectivity();

expect(result, [ConnectivityResult.wifi]);
},
skip: !Platform.isAndroid ||
Platform.operatingSystemVersion.contains('5.0.2'));
Platform.operatingSystemVersion.contains('7.0'));

testWidgets('connectivity on Android 5 (API 21) should be mobile',
testWidgets('connectivity on Android 7 (API 24) should be mobile',
(WidgetTester tester) async {
final result = await connectivity.checkConnectivity();

expect(result, [ConnectivityResult.mobile]);
},
skip: !Platform.isAndroid ||
!Platform.operatingSystemVersion.contains('5.0.2'));
!Platform.operatingSystemVersion.contains('7.0'));

testWidgets('connectivity on MacOS should be ethernet',
(WidgetTester tester) async {
Expand Down
Loading