Add optional pushProvisioned hint to notification preferences view#82
Merged
Conversation
Thread an optional, backward-compatible pushProvisioned flag (default true) into the notification preferences view. When a host passes false, a subtle heads-up renders beneath the push channel toggle so the user knows push cannot deliver until the integration is provisioned. Existing consumers that do not thread the flag are unaffected.
There was a problem hiding this comment.
Pull request overview
Adds an opt-in pushProvisioned flag to the notification preferences view so host apps can indicate whether push delivery is actually provisioned; when not provisioned, the UI shows a subtle hint under the push channel label to set user expectations during the notification-delivery phase-2 rollout.
Changes:
- Added an optional
pushProvisionedconstructor parameter (defaulttrue) to keep existing callers backward-compatible. - Rendered a “push not yet configured” hint under the push channel label when
pushProvisioned == false.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The push-not-provisioned hint shipped with hardcoded English copy and
sat inside the label's ExcludeSemantics, so it was untranslatable and
invisible to a screen reader.
It now reads trans('notifications.channel_push_unconfigured') like every
other string in the view, with the key added to the published en lang
stub. The exclusion moved down to wrap only the channel label (its
reason is unchanged: the switch carries the same text as its
semanticLabel, so an E2E getByLabel must not resolve the paragraph); the
hint sits outside it because it says something the switch label does
not. Three tests cover it: rendered when unprovisioned, absent by
default, and outside the exclusion.
anilcancakir
added a commit
that referenced
this pull request
Jul 25, 2026
…g flag (#83) MagicStarterNotificationController reads meta.push_provisioned off both preference responses into pushProvisionedNotifier, and the preferences view renders the push heads-up while it is false. The view's pushProvisioned param becomes bool? and means override: null (the default) reads the backend flag. #82 shipped that param with no producer, and the most likely host could not even pass it (the starter's own route builds the view). The flag now travels with the data it describes, from magic-starter-laravel#14. Degradation: the flag starts true and only moves on a response that actually carries a bool, so a backend predating meta.push_provisioned never renders a false 'push not configured' claim. The matrix builder listens to both notifiers merged, so a flag that changes on a save rebuilds the toggles too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
pushProvisionedparameter (defaulttrue, backward-compatible) to the notification preferences view. Whenfalse, the view surfaces an info hint telling the user push is not yet configured for the app.Part of the notification-delivery phase-2 rollout: the uptizm backend now exposes
meta.push_provisionedon the notification-channel index, and the uptizm client renders this hint when the app has no OneSignalapp_idprovisioned.Notes
true).flutter analyze: No issues found.mainso the two concerns ship separately.Client counterpart: anilcancakir/uptizm notification-delivery rollout.