Skip to content

Structural history schema authority#57

Open
flyingrobots wants to merge 1 commit into
mainfrom
cycle/CORE_structural-history-schema-authority
Open

Structural history schema authority#57
flyingrobots wants to merge 1 commit into
mainfrom
cycle/CORE_structural-history-schema-authority

Conversation

@flyingrobots
Copy link
Copy Markdown
Owner

Summary

  • add Graft's canonical structural history GraphQL schema
  • commit Wesley-generated TypeScript contracts plus a manifest recording schema, generated artifact, and Wesley L1 hashes
  • add deterministic schema/generated artifact drift checks and focused contract tests
  • document the first implementation status and file bad-code for making Wesley CLI regeneration hermetic in Graft CI

Verification

  • pnpm schema:structural-history:check
  • pnpm exec vitest run test/unit/contracts/graft-structural-history-schema.test.ts
  • pnpm typecheck
  • pnpm lint
  • NODE_OPTIONS=--no-deprecation pnpm test:local (one unrelated playback timed out in full host run; direct rerun passed)
  • NODE_OPTIONS=--no-deprecation pnpm exec vitest run tests/playback/WARP_dead-symbol-detection.test.ts
  • pnpm test (Docker isolated): 221 files / 1608 tests passed

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2026

Warning

Rate limit exceeded

@flyingrobots has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 34 minutes and 42 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9198a26e-4818-4c7d-9b3c-05ed91943ccc

📥 Commits

Reviewing files that changed from the base of the PR and between 9f83c4f and 89a7641.

⛔ Files ignored due to path filters (6)
  • CHANGELOG.md is excluded by !**/*.md
  • docs/design/CORE_structural-history-schema-and-echo-migration.md is excluded by !**/*.md
  • docs/method/backlog/bad-code/CLEAN_wesley-cli-not-hermetic-in-graft-ci.md is excluded by !**/*.md
  • docs/method/backlog/dependency-dag.dot is excluded by !**/*.dot
  • docs/method/backlog/dependency-dag.svg is excluded by !**/*.svg
  • src/generated/graft-structural-history.ts is excluded by !**/generated/**
📒 Files selected for processing (6)
  • eslint.config.js
  • package.json
  • schemas/graft-structural-history.graphql
  • schemas/graft-structural-history.manifest.json
  • scripts/check-structural-history-schema-artifacts.ts
  • test/unit/contracts/graft-structural-history-schema.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cycle/CORE_structural-history-schema-authority

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 89a7641b90

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +112 to +114
if (manifest.wesleyCliVersion !== "0.0.4") {
violations.push(`Unexpected Wesley CLI version ${manifest.wesleyCliVersion}; expected 0.0.4.`);
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Validate the pinned Wesley L1 registry hash

checkStructuralHistorySchemaArtifacts enforces wesleyCliVersion but never verifies manifest.wesleyL1RegistryHash, so a commit can change the recorded L1 hash to any value and still pass the new contract check/test. In this commit that hash is positioned as part of the schema authority/provenance guardrail, so leaving it unchecked creates a silent integrity gap for future schema artifact updates.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant