Conversation
mbstadler
approved these changes
Jul 28, 2026
mbstadler
left a comment
mbstadler
left a comment
Collaborator
There was a problem hiding this comment.
That looks all great. Two minor thoughts:
- would it make sense to keep the ellipsis to avoid potential breaking of existing code? (see also in-line comment)
- should we add something to the NEWS file?
| #' @export | ||
| plotEISA <- function(x, contrast = c("ExIn", "none"), | ||
| minLfc = NULL, maxFDR = 0.05, | ||
| genecolors = c("#E41A1C", "#497AB3", "#222222"), ...) { |
Collaborator
There was a problem hiding this comment.
Assuming some people use plotEISA(...) with additional graphical arguments in the ellipsis to be passed to plot(...), this will be a breaking change. What about keeping the ellipsis, but checking if it is non-empty and throw a warning in that case?
Collaborator
Author
|
Yes, both good points, thanks - I added back the ellipsis and updated the NEWS file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.