CIRC-2538: Refactor item location handling to use locationRepository directly for effective location retrieval#1681
Merged
Merged
Conversation
…directly for effective location retrieval
|
pfilippov-epam
approved these changes
Jul 14, 2026
mukhiddin-yusuf
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix retrievalServicePointName showing "DCB" instead of the real service point name for ECS LOC requests. In the Central tenant, shadow locations have primaryServicePoint pointing to the DCB service point UUID, but carry the real SP name in effectiveLocationPrimaryServicePointName. The previous fix (#1679) incorrectly targeted DCB virtual items via routing in ItemRepository and is reverted by this PR.
Approach
The fix is in LocationRepository.fetchPrimaryServicePoint: if the location already has a ServicePoint stub with a non-null name (populated by LocationMapper from effectiveLocationPrimaryServicePointName), return it directly without fetching from storage — which would overwrite the correct name with "DCB"
TODOS and Open Questions
Learning
CIRC-2538