Skip to content

fix: replace deprecated goreleaser archives.format with formats - #188

Open
ascandone wants to merge 2 commits into
mainfrom
fix/goreleaser-deprecated-format
Open

ascandone wants to merge 2 commits into
mainfrom
fix/goreleaser-deprecated-format

Conversation

@ascandone

Copy link
Copy Markdown
Contributor

GoReleaser warns on every release:

DEPRECATED: archives.format should not be used anymore
DEPRECATED: archives.format_overrides.format should not be used anymore

Switches both to the formats list form. goreleaser check passes with no warnings; archive names and extensions are unchanged.

@NumaryBot

Copy link
Copy Markdown
Contributor

✅ Approve — automated review

The deprecated scalar fields are correctly migrated to equivalent single-item formats lists without changing archive behavior.

No findings.

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.10%. Comparing base (8a4a03a) to head (e73ba5a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   72.10%   72.10%           
=======================================
  Files          60       60           
  Lines        5621     5621           
=======================================
  Hits         4053     4053           
  Misses       1341     1341           
  Partials      227      227           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shipfox-ai

shipfox-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown

This PR is a minimal two-line migration of .goreleaser.yaml from the deprecated scalar keys archives.format and archives.format_overrides.format to their list-form replacements archives.formats: [tar.gz] and archives.format_overrides.formats: [zip], as required by the GoReleaser v2 schema. I verified both hunks against the checked-out file and confirmed the working tree matches the diff exactly, that both migration sites are covered (none missed), and that no other file or behavior is affected. The change is correct, complete, and internally consistent, and eliminates the deprecation warnings in release CI. Recommendation: approve.

Standards

No confirmed material finding. The repo's only standards document (CONTRIBUTING.md) covers test-snapshot regeneration and grammar generation and imposes no rule touching release configuration. The single judgement-call candidate raised during review — the string-level arch dispatch in the pre-existing name_template (.goreleaser.yaml:34) — is untouched by this diff and is standard GoReleaser config idiom; it does not warrant retention.

Spec

No confirmed material finding. No spec or originating issue is available for this PR; the change is a self-contained tooling-mandated key rename with no functional surface to diverge from.

Reviewed independently by GLM (glm-5.3-flash) and DeepSeek (deepseek-v4-pro-0813) via Shipfox; verified and synthesized by GLM.

@NumaryBot NumaryBot added risk: medium NumaryBot classified this pull request as medium risk. bot-reviewed NumaryBot completed its review workflow for the current head. review-approved The NumaryBot review gate is satisfied for the current head. labels Oct 21, 2026

@NumaryBot NumaryBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required automated review completed with no remaining findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-reviewed NumaryBot completed its review workflow for the current head. review-approved The NumaryBot review gate is satisfied for the current head. risk: medium NumaryBot classified this pull request as medium risk.

Development

Successfully merging this pull request may close these issues.

2 participants