Repository navigation
test(difftest): pin the underscore asset rejection as intended - #224
Merged
Merged
Conversation
Numscript rejects an asset name containing `_` on both engines, while the oracle and ledger accept it. Decided as intended on 2026-10-21: record it in DIVERGENCES.md #8 and pin it with TestUnderscoreAssetVarRejected on main.
NumaryBot
added
risk: low
NumaryBot
approved these changes
Oct 21, 2026
NumaryBot
left a comment
NumaryBot
left a comment
Contributor
There was a problem hiding this comment.
The required automated review completed with no remaining findings.
Azorlogh
approved these changes
Oct 22, 2026
NumaryBot
removed
the
review-approved
ascandone
enabled auto-merge (squash)
October 22, 2026 08:58
NumaryBot
added
the
review-approved
NumaryBot
approved these changes
Oct 22, 2026
NumaryBot
left a comment
NumaryBot
left a comment
Contributor
There was a problem hiding this comment.
The required automated review completed with no remaining findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asset names containing `_` (e.g. `USD_CASH`) are rejected by both numscript engines, while the oracle and ledger accept them. This is the intended behaviour, so it is recorded as a known difference and pinned.
Note: #206's divergence 7 (negative division portion) is not ported here; it is already covered on main by the compiler's `AssertNonNegativePortion`. The table has no row 7 yet, so it reads 1-6, 8.