Repository navigation
MP3 without import maps again; events to measure the helper and hand-offs - #20
Merged
Merged
Conversation
…offs Compatibility (regression from #15): - The encoder bundles import "./mediabunny.min.mjs" and media.js imports the library by path, so no import map is needed. Browsers without import-map support (Safari < 16.4) could not save MP3 anywhere after lamejs was removed; the floor is now what Mediabunny itself needs. Import maps removed from all pages; vendor README documents the one rewrite. Measurement (no file names, contents or typed text): - file_processed gets via: assistant | next | direct (hand-off marks the tool page in sessionStorage). - assistant_pick gets rank and with_settings. - assistant_nomatch: once per visit when the helper can't match a request. - settings_kept: whether settings put in by the helper were unchanged when the file was processed. - Privacy policy lists these events; changelog. Also: build_zh.py runs seo_sync.py at the end, so Chinese FAQ JSON-LD can't be left in English. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016rsS6JgzjZXLy17J1cgACN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Compatibility fix (regression from #15)
After lamejs was replaced by Mediabunny, the encoders were loaded through an import map. Safari supports import maps only from 16.4, so on older iPhones (and browsers of that age) no tool could save MP3, and the converter failed on every format.
./mediabunny.min.mjs, andmedia.jsimports the library by path. No page needs an import map, and all are removed.vendor/mediabunny/README.mddocuments the one rewrite and how to repeat it on update (asedline).??=, Safari 14+). I could not test old Safari here. In Chromium, every page now runs without an import map, and the full conversion suites pass (including the no-WebCodecs fallback).2. Events to evaluate the helper and hand-offs
No file names, file contents or typed text are sent.
file_processedtool,via=assistant/next/directassistant_picktool,method,rank,with_settingsassistant_nomatchmethodsettings_kepttool,kept= yes/noviais set when a tool page picks up a hand-off (sessionStorage, per page path), and read bytoolSuccess.The privacy policy now lists these events and states that helper input is never sent. Changelog updated.
Also
scripts/build_zh.pyrunsseo_sync.pyat the end; before, a build without a manual sync left the Chinese FAQ JSON-LD in English.Checks (headless Chromium)
metrics_e2e: direct →via: direct; helper + "speed up 1.5x" →via: assistant,settings_kept: yes; helper + "louder by 6 dB", then gain changed →settings_kept: no; pick →rank: 1, with_settings: yes; two unmatched requests → oneassistant_nomatchwithout text; "continue with this file" →via: next.After merge (GA4)
Admin → Custom definitions → Create custom dimension (event scope):
tool,via,method,rank,with_settings,kept. Admin → Events → markfile_processedanddonate_clickas key events.Generated by Claude Code