Stop the clusters live-filter from collapsing sections it hasn't searched#828
Open
LukasWallrich wants to merge 2 commits into
Open
Stop the clusters live-filter from collapsing sections it hasn't searched#828LukasWallrich wants to merge 2 commits into
LukasWallrich wants to merge 2 commits into
Conversation
…ched The live filter (Focus/Type tags, specialist toggle, and free-text search - all bound to the same search box) only checked enriched resource cards for matches. A query that only appeared in a sub-cluster's own heading or description text (not any card) produced a match count of 0, which disabled and collapsed that section - including ones plainly relevant to the search. Reproduced on the live page: searching a phrase taken verbatim from a sub-cluster description collapsed 93/93 accordion sections site-wide. Cache each section's own heading+description text alongside its cards, and treat a query match against that text as sufficient to keep the section open (skipping the disable path, then falling through to the existing "isFiltered" branch that auto-expands on match) even with zero matching cards. Only applies with no active Focus/Type facet, since those are card-specific metadata, not something a sub-cluster's own text can satisfy. Verified in browser: the repro phrase now keeps its actual matching section open (accurately showing "0" cards matched, since none individually mention the phrase) while non-matching sections still correctly disable; card-title/summary search and Focus/Type facet filtering are unaffected; clearing the search box still fully restores all sections. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
Contributor
✅ Spell Check PassedNo spelling issues found when checking 7 changed file(s)! 🎉 |
Contributor
Author
|
✅ Staging Deployment Status This PR has been successfully deployed to staging as part of an aggregated deployment. Deployed at: 2026-07-02 15:06:58 UTC The staging site shows the combined state of all compatible open PRs. |
richarddushime
approved these changes
Jul 2, 2026
richarddushime
left a comment
richarddushime
left a comment
Contributor
There was a problem hiding this comment.
one minor issue is that once selected one focus, the rest of the subclusters are deactivated, untill a refresh or selecting All
the links would be better if remained active and collapsed
Contributor
Author
|
@richarddushime I am not sure what behaviour you would suggest? Clear the search when clicking to expand a section? That might be somewhat unexpected behaviour and should then probably also apply to the filters? |
The filter bar had no explicit reset: getting back to everything meant backspacing the search box and clicking "All" on each facet. A Focus tag also greys out non-matching sub-clusters, so a filtered view could feel stuck until refresh. Add a "Clear filters" chip that appears only when a restrictive filter (search text or a non-"All" Focus/Type tag) is active. Clicking it empties the search box, resets Focus/Type to "All", unchecks the specialist toggle, re-applies filtering, and refocuses the search input. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
initFiltering().isFilteredbranch that auto-expands on match) even with zero matching cards.Test plan
🤖 Generated with Claude Code