-
Notifications
You must be signed in to change notification settings - Fork 55
Docker Support #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Support #555
Changes from 1 commit
e327b20
347a33b
3e532d3
4d95de0
6074e77
35d4211
8e2d95c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -14,6 +14,7 @@ | |||||
| # SPDX-FileCopyrightText: 2021-23 Samuel Tyler <samuel@samuelt.me> | ||||||
| # SPDX-FileCopyrightText: 2023-24 Gábor Stefanik <netrolller.3d@gmail.com> | ||||||
| # SPDX-FileCopyrightText: 2024 Lance Vick <lance@vick.house> | ||||||
| # SPDX-FileCopyrightText: 2025 Kevin Nause <kevin@nause.engineering> | ||||||
|
|
||||||
| import argparse | ||||||
| import os | ||||||
|
|
@@ -42,8 +43,8 @@ def create_configuration_file(args): | |||||
| config.write(f"FINAL_JOBS={args.cores}\n") | ||||||
| config.write(f"INTERNAL_CI={args.internal_ci or False}\n") | ||||||
| config.write(f"INTERACTIVE={args.interactive}\n") | ||||||
| config.write(f"BARE_METAL={args.bare_metal}\n") | ||||||
| config.write(f"EXTERNAL_SOURCES={args.external_sources}\n") | ||||||
| config.write(f"QEMU={args.qemu}\n") | ||||||
| config.write(f"BARE_METAL={args.bare_metal or (args.qemu and args.interactive)}\n") | ||||||
| if (args.bare_metal or args.qemu) and not args.kernel: | ||||||
| if args.repo or args.external_sources: | ||||||
| config.write("DISK=sdb1\n") | ||||||
|
|
@@ -262,15 +263,17 @@ def bootstrap(args, generator, target, size, cleanup): | |||||
| generator.prepare(target, using_kernel=False) | ||||||
| arch = stage0_arch_map.get(args.arch, args.arch) | ||||||
| init = os.path.join(os.sep, 'bootstrap-seeds', 'POSIX', arch, 'kaem-optional-seed') | ||||||
| print(generator.target_dir, init) | ||||||
| run('env', '-i', 'DOCKER_BUILDKIT=1', 'SOURCE_DATE_EPOCH=1', | ||||||
| 'docker', 'build', | ||||||
| '--build-arg=SOURCE_DATE_EPOCH=1', | ||||||
| '--progress=plain', | ||||||
| '--platform=linux/amd64', | ||||||
| '--target=package', | ||||||
| '--tag', 'local/live-bootstrap', | ||||||
| '.') | ||||||
| target_rel = os.path.relpath(generator.target_dir, os.getcwd()) | ||||||
| run('env', '-i', 'DOCKER_BUILDKIT=1', | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we hardcode DOCKER_BUILDKIT=1 here? Won't this cause needless failures on systems without BuildKit installed (e.g. systems with older Docker versions)?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was a part of #413. If you don't want it, remove it.
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are you willing to guide this PR to a mergeable state? This needs addressing from my perspective to be merged. If you aren't willing to guide this PR to be merged, that's fine - no one owes anyone anything in open source - but I won't keep this PR open indefinitely in that case.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I write code not comments. |
||||||
| 'docker', 'build', | ||||||
| '--build-arg=ARCH='+ arch, | ||||||
| '--build-arg=TARGET=' + target_rel, | ||||||
| '--build-arg=SOURCE_DATE_EPOCH=1', | ||||||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to above, let's make this 0.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| '--progress=auto', | ||||||
| '--platform=linux/amd64', | ||||||
| '--target=package', | ||||||
| '--tag=live-bootstrap', | ||||||
| '.') | ||||||
|
|
||||||
| elif args.bwrap: | ||||||
| init = '/init' | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know what the purpose of all this is?