fix(report): raise FossologyApiError when report ID cannot be parsed

[Valyrian-Code]

Summary

Closes #176.

In fossology/report.py:56, the regex used to extract the report ID from the API response message was:

report_id = re.search("[0-9]*$", response.json()["message"])
return report_id[0]

[0-9]* (zero or more) always matches — even on a string with no trailing digits — so re.search returns a match object whose group 0 is an empty string "". The caller received that empty string with no error raised, and the failure surfaced later as a confusing 404 or type error inside download_report.

Change

• Switch the quantifier to [0-9]+$ (one or more)
• Raise FossologyApiError if no ID can be parsed, with a descriptive message that includes the original response text
• Drop the # type: ignore since match is now narrowed to non-None before use

Compatibility

Happy-path behaviour is identical: a message like "Report will be generated in the back ground, report id is 42" still parses to "42". The only behaviour change is that callers now get a clear exception instead of a silent empty string when the message format is unexpected.

Test plan

• New regression test test_generate_report_unparseable_message mocks a 201 response with no trailing digits and asserts FossologyApiError is raised
• pytest tests/test_report.py::test_generate_report_unparseable_message passes locally
• ruff check clean
• CI green

Open questions for maintainers

1. Return type: the function's docstring says :rtype: int but the function returns str. I kept it as str to minimise the diff. Happy to coerce to int and update the docstring in a follow-up if you'd prefer.
2. Error class: I raised FossologyApiError since a real response is in hand. Let me know if a dedicated parsing exception would fit better.

[Copilot]

Pull request overview

This PR improves generate_report error handling by making report ID parsing fail clearly when the FOSSology API response message does not end with a numeric ID.

Changes:

• Requires at least one trailing digit when extracting the report ID.
• Raises FossologyApiError when parsing fails.
• Adds a regression test for an unparseable report-generation response message.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
fossology/report.py	Updates report ID parsing and adds explicit parse-failure handling.
tests/test_report.py	Adds regression coverage for a 201 report response without a parseable report ID.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Valyrian-Code]

Hi @deveaud-m ,

I’ve provided a minimal patch for this PR. Could you please review it when you have a chance?