Handler improvements#73
Merged
Merged
Conversation
Signed-off-by: Andy Doan <andy@foundries.io>
vkhoroz
approved these changes
Oct 23, 2025
Comment on lines
+32
to
+36
| for range 2 { | ||
| if err := <-done; err != nil { | ||
| slog.Error("Error reading command output", "error", err) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
IMHO it'd be more clear what's going on if you replace a channel with sync.WaitGroup.
IIUC prefixAndCopy can log its error itself; removing any benefit from using a channel.
Member
Author
There was a problem hiding this comment.
good call. I started to do that but originally thought I'd handle the error differently. This will simplify
| cmd.Stderr = os.Stderr | ||
| if err := cmd.Run(); err != nil { | ||
|
|
||
| if err := ExecIndented(cmd, "| "); err != nil { |
Prefix all the change handler output with "| " so that our logs are easier to follow Signed-off-by: Andy Doan <andy@foundries.io>
doanac
force-pushed
the
handler-improvments
branch
from
139eda7 to
901521a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes make it easier to use on-change handlers. Then end result is something like: