fiotest: Update the way we set the test "target"#79
Merged
Conversation
When we run remote-actions we must set a "target" to use the fiotest backend APIs. However, by setting x-ats-target, the device gateway may update the device's actual target name while fiotest is running leading to confusion. The device gateway was changed to allow a target name to be set in the test body to work around this. Signed-off-by: Andy Doan <andy@foundries.io>
mike-sul
approved these changes
Feb 23, 2026
detsch
approved these changes
Feb 23, 2026
Contributor
|
@doanac Will we need to bump this fioconfig version in fioup? |
Member
Author
yes. i'll be testing this in staging today to sort that out. |
Member
Author
|
tested in staging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we run remote-actions we must set a "target" to use the fiotest backend APIs. However, by setting x-ats-target, the device gateway may update the device's actual target name while fiotest is running leading to confusion.
The device gateway was changed to allow a target name to be set in the test body to work around this.