feat: error when foundry binaries are in use#66
Merged
DaniPopes merged 6 commits intoJun 11, 2026
Conversation
stevencartavia
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
onbjerg
as code owners
DaniPopes
previously approved these changes
Jun 9, 2026
Member
|
can we rename the tests or move them all into one module so that we can easily make the nextest filter catch all of them? |
mablr
previously approved these changes
Jun 10, 2026
Amp-Thread-ID: https://ampcode.com/threads/T-019eb215-3819-765c-a288-2f57069d8253 Co-authored-by: Amp <amp@ampcode.com> # Conflicts: # src/install.rs # tests/it/main.rs
Amp-Thread-ID: https://ampcode.com/threads/T-019eb215-3819-765c-a288-2f57069d8253 Co-authored-by: Amp <amp@ampcode.com>
mablr
approved these changes
Jun 10, 2026
DaniPopes
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_bins_in_usenow errors and exits whenforge/cast/anvil/chiselis running (exact, global name match), instead of only warning, and runs it on the--usepath. This prevents overwriting a binary that's in use. Matches the legacypgrep -xbehavior.Part of OSS-334