fix: match bash installer arch fallback and command checks#69
Conversation
stevencartavia
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
onbjerg
as code owners
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| } | ||
|
|
||
| async fn install_from_local(config: &Config, local_path: &Path, args: &Cli) -> Result<()> { | ||
| need_cmd("cargo")?; |
There was a problem hiding this comment.
this still runs after startup side effects: main has already migrated config, started the update check, printed the banner, checked running bins, and install::run has created dirs. if the goal is to fail before doing any work, this check likely needs to be hoisted to the top-level dispatch.
There was a problem hiding this comment.
Confirmed live: with cargo missing, foundryup --path ... still prints the banner and creates .foundry/{bin,versions,share/man/man1} before need 'cargo'; with git missing, foundryup --branch ... does the same before need 'git'. So this thread is still relevant.
Tests: targeted tests pass; full suite passes when foundry_bins is run serially.
3 participants
--arch/FOUNDRYUP_ARCH: unifyArch::detectandArch::from_strinto one normalization that falls back to amd64 for unrecognized values (instead of erroring) and resolves a literalx86_64to arm64 under Rosetta — matchingdetect_platform_archgit/cargoup front and fail with a clearneed 'X' (command not found)message before doing any workPart of OSS-334