fix(slack): force non-webp persona avatars so Slack renders them - #9
Open
debuggingfuture wants to merge 2 commits into
Open
fix(slack): force non-webp persona avatars so Slack renders them#9debuggingfuture wants to merge 2 commits into
debuggingfuture wants to merge 2 commits into
Conversation
Slack's icon_url accepts only jpeg/png/gif and silently drops webp, which fandom's CDN serves by default — so seeded intros showed the default app icon instead of the persona's face. Append the format=original param PERSONAS.md already documents to all 8 avatar URLs, and tighten validateAvatar to reject non-jpeg/png/gif so this fails loudly next time.
Workspace-level and org-level installs of the same app are distinct bot identities; intros posted by a previous install can't be deleted by the current one. Warn and continue instead of aborting the re-seed.
debuggingfuture
marked this pull request as ready for review
June 10, 2026 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persona intros in Slack showed the default app icon instead of each persona's face. Fixed and validated live — re-seeded
#pied-piperand Slack now ingests/re-hosts every avatar (its tell for a successfully processed icon).Root cause: Slack's
icon_urlrenders only jpeg/png/gif and silently drops webp — and fandom's CDN content-negotiates every image to webp by default. Theformat=originalconvention was already documented in PERSONAS.md prose but the 8avatar_urlvalues had drifted from it.format=originalto all 8 personaavatar_urls (nowimage/jpeg/image/png).validateAvatarto accept only jpeg/png/gif so a webp avatar fails loudly at seed time instead of silently rendering the default icon.--replace: toleratecant_delete_message(intros posted by a previous app install are a different bot identity — workspace-level vs org-level installs don't share one) with a warning instead of aborting.