fix: handle detached HEAD state in bench update & add --app-name override for get-app#1708
Open
RendaniSinyage wants to merge 4 commits intofrappe:developfrom
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What type of a PR is this?
Please provide enough information so that others can review your pull request:
This PR combines two changes:
1. Bug Fix — Detached HEAD crash in
bench updateWhen an app is pinned to a tag or commit,
git symbolic-ref -q --short HEADfails with exit code 1, crashingbench updateentirely.bench/utils/app.py—get_current_branchwraps the git command in atry/except; returnsNoneif in Detached HEAD state (e.g. pinned tag)bench/app.py—pull_appschecksif not branch; prints a skip message and callscontinue, allowing the rest of the update to proceed2. Enhancement —
--app-nameoverride forbench get-appAllows renaming the cloned app folder on disk at install time (e.g. cloning
rpaasaspaas).bench/commands/make.py— adds--app-nameclick option withdefault=Nonebench/app.py— after cloning, ifapp_nameis provided and differs fromapp.repo, renames the folder usingos.renameand updates bothapp.app_nameandapp.repoScreenshots/GIFs
N/A - CLI fix.