fix(jobs): replaced deprecated command argument --no-mariadb-socket by the recommanded --mariadb-user-host-login-scope='%' (wildcard)#261
Open
fjudith wants to merge 1 commit intofrappe:mainfrom
Conversation
… by the recommanded `--mariadb-user-host-login-scope='%'` (wildcard)
Contributor
|
if i'm not mistaken, this would break v14 and earlier deployments, if any, unless, we drop support for those versions, which idk if it's unlikely or not. |
Collaborator
|
Can you resolve conflict? https://discuss.frappe.io/t/reminder-erpnext-v14-has-reached-end-of-life/160084 We can merge I guess |
Contributor
|
Can we make it adjustable with a key that lets us choose which route this would take? That way we won’t break existing installations, although given the nature of it, this is really only used for new sites anyway. Still, I believe we should always maintain compatibility. just my 2 cents |
Contributor
|
This PR has been automatically marked as stale. You have a week to explain why you believe this is an error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
create-siteuses the deprecated--no-mariadb-socketcommand line argument.Using the recommended
--mariadb-user-host-login-scope='%'has been tested successfully