Fix: correct site name correctly in backup and drop multiple site jobs#280
Open
disha-itpl wants to merge 9 commits intofrappe:mainfrom
Open
Fix: correct site name correctly in backup and drop multiple site jobs#280disha-itpl wants to merge 9 commits intofrappe:mainfrom
disha-itpl wants to merge 9 commits intofrappe:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue in the
backup-multiple-sitesanddrop-multiple-sitesHelm job templates where the full site map was being passed to the--siteflag instead of the actual site name.Problem
The jobs iterate over:
However, the template previously used:
Since
$siteis a map (e.g.,map[name:frappe.helpdesk.local]), the generated command became invalid:This caused the jobs to fail.
Fix
Updated the templates to correctly reference:
This ensures the generated command is:
The same correction has been applied to both:
Validation