Open
Conversation
- Add erpnext.commonPodLabels template for user-defined pod labels - Template only includes custom labels, preserves existing labels - Returns empty string when commonPodLabels is not defined
- Update all deployment templates to include commonPodLabels - Add commonPodLabels as separate block after existing pod labels - Preserve original labels (app.kubernetes.io/name, instance, app: frappe) - Apply to all components: nginx, gunicorn, socketio, scheduler, workers
- Add commonPodLabels section with comprehensive documentation - Provide clear examples for common use cases (environment, team, etc.) - Default to empty object for backward compatibility - Include usage examples in comments
Contributor
|
@suraj2410 this is actually good, how about putting it under a key called global? we can later add other things such as annotations, tolerations etc for the whole deployment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces common pod labels support for ERPNext deployments, allowing the same labels to be applied to all pods across all deployments in a single Helm release.
What's included
commonPodLabelshelper template for user-defined pod labelscommonPodLabelsconfiguration to values.yaml with examplesKey Features
{}or missingcommonPodLabelsconfigurationUsage Example
Backward compatibility
Testing
All deployments (nginx, gunicorn, socketio, scheduler, workers) will now include:
Fixes common requirement for applying organization-wide labels to Kubernetes resources.