BTRL - Banca Transilvania Romania#87
Open
avramflorin wants to merge 1 commit into
Open
Conversation
sevannerse
reviewed
Apr 8, 2021
| 1100 => Engine\Kbs::class, | ||
| 1200 => Engine\Zetb::class, | ||
| 1300 => Engine\Kontist::class, | ||
| 1100 => Engine\Btrl::class, |
Collaborator
There was a problem hiding this comment.
Kbs, Zetb and Kontist should not be deleted.
sevannerse
reviewed
Apr 8, 2021
| $this->assertEquals('15-12-2016', $transactions[1]->getValueTimestamp('d-m-Y')); | ||
| $this->assertEquals('15-12-2016', $transactions[1]->getEntryTimestamp('d-m-Y')); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
test methods should not be deleted.
sevannerse
reviewed
Apr 8, 2021
| $lastTransaction = end($transactions); | ||
| $this->assertEquals('02-01-2020', $lastTransaction->getEntryTimestamp('d-m-Y')); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
test methods should not be deleted.
sevannerse
reviewed
Apr 8, 2021
| $lastTransaction = end($transactions); | ||
| $this->assertEquals('24-05-2019', $lastTransaction->getEntryTimestamp('d-m-Y')); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
test methods should not be deleted.
sevannerse
reviewed
Apr 8, 2021
| $lastTransaction = end($transactions); | ||
| $this->assertEquals('2010-07-21', $lastTransaction->getEntryTimestamp('Y-m-d')); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
test methods should not be deleted.
sevannerse
reviewed
Apr 8, 2021
| $price_f = $statements[0]->getEndPrice(); | ||
| $this->assertSame(13057.49 , $price_f); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
test methods should not be deleted.
sevannerse
reviewed
Apr 8, 2021
| $lastTransaction = end($transactions); | ||
| $this->assertEquals('30-09-2020', $lastTransaction->getEntryTimestamp('d-m-Y')); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
test methods should not be deleted.
sevannerse
reviewed
Apr 8, 2021
| $statements = $this->engine->parse(); | ||
| $this->assertSame('PmtInfId-20151208-987', $statements[0]->getTransactions()[1]->getDescription()); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
test methods should not be deleted.
sevannerse
reviewed
Apr 8, 2021
| $this->assertEquals('18-02-2010', $last->getStartTimestamp('d-m-Y')); | ||
| $this->assertEquals('18-02-2010', $last->getEndTimestamp('d-m-Y')); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
test methods should not be deleted.
Owner
|
Seems that this might need a rebase on the latest @avramflorin might that resolve the various issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add new Engine for BT Banca Transilvania