Use System.Text.Json instead of Newtonsoft.Json in Fake.Core.IntegrationTests#2844
Merged
Conversation
Numpsy
commented
Dec 19, 2024
| { File = string (t.GetProperty("file")) | ||
| Line = t.GetProperty("line").GetInt32() | ||
| Column = t.GetProperty("column").GetInt32() | ||
| ErrorDetail = string (t.GetProperty("errorDetail")) } |
Contributor
Author
There was a problem hiding this comment.
Note: uses string instead of .GetString() because GetString() can return null and the tests expect missing string properties to be an empty string rather than null
Contributor
xperiandri
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A small follow up to #2839 in case it's useful - only effects the tests, but drops a dependency on Newtonsoft.Json - the integration test project is built as .NET 6 so it always has System.Text.Json available in box