Skip to content

Allow Long scalar coercion from integer literals during AST input validation #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xperiandri merged 2 commits into from
May 17, 2026
Merged

Allow Long scalar coercion from integer literals during AST input validation #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61e728f
Initial plan
Copilot May 17, 2026
01eafce
Fix Long scalar inline integer validation and add regression test
Copilot May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FSharp.Data.GraphQL.Shared/Validation.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,7 @@ module Ast =
| _ when tref.Kind = TypeKind.NON_NULL -> checkIsCoercible tref.OfType.Value argName value
| IntValue _ ->
match tref.Name, tref.Kind with
| Some ("ID" | "Int" | "Float"), TypeKind.SCALAR -> Success
| Some ("ID" | "Int" | "Long" | "Float"), TypeKind.SCALAR -> Success
| _ -> canNotCoerce
| FloatValue _ ->
match tref.Name, tref.Kind with
Expand Down
10 changes: 10 additions & 0 deletions tests/FSharp.Data.GraphQL.Tests/AstValidationTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,12 @@ let Arguments =
[ Define.Input ("intArg", Nullable IntType) ],
(fun ctx _ -> ctx.Arg ("intArg"))
)
Define.Field (
"longArgField",
Nullable LongType,
[ Define.Input ("longArg", Nullable LongType) ],
(fun ctx _ -> ctx.Arg ("longArg"))
)
Define.Field (
"nonNullBooleanListField",
ListOf BooleanType,
Expand Down Expand Up @@ -1020,6 +1026,10 @@ fragment coercedIntIntoFloatArg on Arguments {
floatArgField(floatArg: 123)
}

fragment coercedIntIntoLongArg on Arguments {
longArgField(longArg: 123)
}

query goodComplexDefaultValue($search: ComplexInput = { name: "Fido" }) {
findDog(complex: $search)
}"""
Expand Down
Loading