remove old SA1019 lint:ignore - #574
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes now-unnecessary //lint:ignore SA1019 annotations (previously used to silence staticcheck deprecation warnings) because SA1019 is already globally excluded in this repo’s staticcheck invocation. It also updates .gitignore to ignore local Claude tooling metadata.
Changes:
- Remove per-import
//lint:ignore SA1019comments across library code, CLI, and tests. - Remove the remaining
//lint:ignore SA1019nearproto.MessageTypeusage informat.go. - Add
.claude/to.gitignore.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| invoke.go | Drops per-import SA1019 ignore annotations from deprecated protobuf/protoreflect imports. |
| grpcurl.go | Drops per-import SA1019 ignore annotations from deprecated protobuf/protoreflect imports. |
| grpcurl_test.go | Drops per-import SA1019 ignore annotations in tests. |
| format.go | Drops per-import ignores and removes the remaining SA1019 ignore comment near proto.MessageType. |
| format_test.go | Drops per-import SA1019 ignore annotations in tests. |
| desc_source.go | Drops per-import SA1019 ignore annotations from deprecated protobuf/protoreflect imports. |
| cmd/grpcurl/grpcurl.go | Drops per-import SA1019 ignore annotation in the CLI package. |
| .gitignore | Ignores .claude/ directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dragonsinth
enabled auto-merge (squash)
July 27, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a global exclude on this one.
Note
Low Risk
Comment and gitignore-only cleanup with no runtime or API behavior changes.
Overview
Removes per-import
//lint:ignore SA1019comments across the library, CLI, and tests now that staticcheck already excludes SA1019 globally (inherit,-SA1019in the Makefile). Import lines are unchanged aside from dropping those annotations; one similar ignore aboveproto.MessageTypeinformat.gois removed as well.Also adds
.claude/to.gitignoreso local Claude tooling files are not tracked.Reviewed by Cursor Bugbot for commit 6e88f15. Bugbot is set up for automated code reviews on this repo. Configure here.