Skip to content

remove old SA1019 lint:ignore - #574

Merged
dragonsinth merged 1 commit into
masterfrom
cleanup
Jul 27, 2026
Merged

remove old SA1019 lint:ignore#574
dragonsinth merged 1 commit into
masterfrom
cleanup

Conversation

@dragonsinth

@dragonsinth dragonsinth commented Jul 27, 2026

Copy link
Copy Markdown
Member

We have a global exclude on this one.


Note

Low Risk
Comment and gitignore-only cleanup with no runtime or API behavior changes.

Overview
Removes per-import //lint:ignore SA1019 comments across the library, CLI, and tests now that staticcheck already excludes SA1019 globally (inherit,-SA1019 in the Makefile). Import lines are unchanged aside from dropping those annotations; one similar ignore above proto.MessageType in format.go is removed as well.

Also adds .claude/ to .gitignore so local Claude tooling files are not tracked.

Reviewed by Cursor Bugbot for commit 6e88f15. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI review requested due to automatic review settings July 27, 2026 19:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes now-unnecessary //lint:ignore SA1019 annotations (previously used to silence staticcheck deprecation warnings) because SA1019 is already globally excluded in this repo’s staticcheck invocation. It also updates .gitignore to ignore local Claude tooling metadata.

Changes:

  • Remove per-import //lint:ignore SA1019 comments across library code, CLI, and tests.
  • Remove the remaining //lint:ignore SA1019 near proto.MessageType usage in format.go.
  • Add .claude/ to .gitignore.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
invoke.go Drops per-import SA1019 ignore annotations from deprecated protobuf/protoreflect imports.
grpcurl.go Drops per-import SA1019 ignore annotations from deprecated protobuf/protoreflect imports.
grpcurl_test.go Drops per-import SA1019 ignore annotations in tests.
format.go Drops per-import ignores and removes the remaining SA1019 ignore comment near proto.MessageType.
format_test.go Drops per-import SA1019 ignore annotations in tests.
desc_source.go Drops per-import SA1019 ignore annotations from deprecated protobuf/protoreflect imports.
cmd/grpcurl/grpcurl.go Drops per-import SA1019 ignore annotation in the CLI package.
.gitignore Ignores .claude/ directory.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dragonsinth
dragonsinth enabled auto-merge (squash) July 27, 2026 19:37

@franklinlindemberg franklinlindemberg left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dragonsinth
dragonsinth merged commit 5f2d0c2 into master Jul 27, 2026
5 checks passed
@dragonsinth
dragonsinth deleted the cleanup branch July 27, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants