Sequence form#613
Merged
Merged
Conversation
tturocy
requested changes
Nov 17, 2025
tturocy
left a comment
tturocy
left a comment
Member
There was a problem hiding this comment.
See individual notes on the files - there's not a need to be creating a separate file, the internal data members of the "collection" classes should now be a BehaviorSupportProfile * instead of referring to the sequence form object.
…nd GetSequenceContingencies
tturocy
approved these changes
Nov 18, 2025
Member
|
I did one additional step, because I was in the neighbourhood, which is to make the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the need for wrapper classes in gameseq.h